Eliminate $lastWeeksGatheredTotals

On further investigation, everything in $lastWeeksGatheredTotals is either duplicate data, or sums of existing data, and it looks like we don't really need any of it. Rework the report logic to build the sums at reporting time instead of collecting and storing the data. Map/reduce is magic.

Fixes #2104 (closed)

changed the description

mentioned in commit 768da3b6

merged

@svornost amazing, thank you.

edit: did a comparison, took my save from 675kb to 645kb.

whoa I played 150 weeks and my save only hit 435kb, how long do you guys usually keep a campaign going?

Week 387. I should really re-roll at this point, but the fun for me at this point is less playing the game and more working on it. Developer's curse.

Week and save size aren't directly correlated. Slave count is the biggest impact on save size. You can run a campaign pretty much indefinitely as long as you're willing to cull weak slaves out of your stable regularly.

Yeah, but then they get sad. Being a Paternalist.... simp life.

This is in reply to lowercasedonkey.... but when I tried to reply it did something weird to my comment so I deleted it and repasted it here.

You'd probably get a better testing environment with more frequent restarts, since I assume most players don't play that long. For instance the one/two bugs I just discovered this morning which can only be discovered before week 1.

Although on week 387 you must get some gigantic battles to test with 1000s of invaders or w/e since as far as I know that's the main thing that scales up past week100?

Some bugs only show up on new games... but some only show up with very old data. I'm always hunting for old saves to give the backwardsCompatibility code a good workout.

A common situation is for someone to drop the game for ages, and then come back, update, and break their save. Some people are even coming in from vanilla, if you can believe it.

As long as we have a mix of old and new being played and reported, it's fine.

edit: the battles get extremely tedious for me after a while so I play without the mods.

The last step of battle scaling is at 120 weeks anyway. It's constant after that.