Skip to content
Snippets Groups Projects

Try to use powershell to strip path information before it pollutes the output file

Merged svornost requested to merge svornost/fc-pregmod:pregmod-master into pregmod-master

When building the list of Javascript files to append, we currently stick the file's full name (including path) into the output file.

This change uses powershell to remove the absolute path information. This is beneficial for two reasons:

  1. We should not be leaking path information into the compiled output. In particular, paths may contain usernames which could be considered sensitive information.
  2. Paths on non-English systems may contain characters outside of ASCII, which cause problems (see #2220 (closed), for instance)

If powershell is not present or not functional on the user's system, the build script will simply continue doing what it does now. It's a standard windows component now (in Windows 8 and later at least), so that should be rare.

Note that this MR also temporarily changes the active codepage to 65001 to allow paths with arbitrary characters. Codepage 65001 is known to be broken on Windows Vista and earlier; I assume we don't care.

Merge request reports

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 2 commits and 1 merge commit will be added to pregmod-master.
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading