Move triggers from slaves to arrays

My goal beyond this MR is to move some some very rarely needed slave properties into global arrays. Some of these properties are documented and some not. They are:

• birth
• induce
• burst
• death

They are almost never needed, and I won't have to loop over the entire slave array in place like the birth scene to find the slaves that are flagged.

This MR moves toward that goal by using functions as middlemen, to make the future switch more painless.

If there are any more like this, please let me know.

changed the description

Induce is the really questionable one here. It can also be applied to the player, which will need to be kept in sync.

Burst, too, technically.

A few ways I can see to handle it.

• Diverge the structure of the PC object.
• Pass PC ID as -1 to the new arrays.
• Make a new global bool just for the PC's induce state, and one for pc burst.

Was that a list or an example? Wasn't exactly clear.

I'd prefer to work them the same way, so a catch in the function seems preferable since a lot of others behaved the same way.

Passing the -1 and sorting it out during processing may be the best though.

Sorry, I'll edit. And I think the first is the worst probably, since we're trying to keep the structures close long term.

edit: I see PC.labor and PC.burst but not actually PC.induce. And it doesn't seem to have any overlap at all with slave loops. May just be easiest to go from PC.labor to PClabor if that's ok.

I could have sworn?

Anyway, that would be fine.

Ok. I don't plan any additions to this MR, and it shouldn't be making any real changes beyond introducing these middlemen functions.

That is fine so long as it gets in before the player overhaul reaches those parts. Of them, I can see induce being used, while burst may be relegated to long term plans.

Ok, this should be simplified now to be only the middle men. Ready if you are.

Basic tests run? The immediate birth startingGirl options should be ideal.

Looking at the file change list though, I'm not seeing it on there. Is that a problem?

Or, let me guess, it uses .labor.

Hmm, would it be in startingGirls.tw? I can't find either. Maybe they are just very, very pregnant?

No, no. I know they are staged to 100% give birth that week. Give me a sec.

Np. I'm not sure if you are talking about the cheatmode starting slaves or a different set but I can't find anyone with a high preg on either start.

Huh. Apparently they don't? "ready to drop" will take you right to it in the .tw one.

I guess that is a moot point then.

Ahh, pregweek 40. That'll do it.

Aye. Older style instead of forcing it with a variable. Pretty much guaranteed either way.

I suppose this is good then? All ready on your end?

Yeah, thanks for your patience.

No problem. Anything is better than trying to figure out what to do with that massive too big bodypart segment I'm staring at.

added 1 commit

• 78a4e520 - always start labor from induce

Compare with previous version

Also be very careful around saLongTermEffects since I am working on converting it to JS. As long as you aren't in the demarcated zone, you should be fine.

The tailing end is right above the language stuff, which should be acting as a buffer between what you are working on and what I am.

added 2 commits

• 76f92ea8 - revert quickly
• ec23f6b6 - revert

Compare with previous version

merged

mentioned in commit 424c1240

mentioned in merge request !8041 (merged)