Skip to content
Snippets Groups Projects

SI: highlight rule selections

1 unresolved thread

Merge request reports

Approval is optional

Merged by PregmodderPregmodder 4 years ago (Oct 13, 2020 3:41am UTC)

Merge details

  • Changes merged into pregmod-master with 0aaa1189.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • @svornost i HATE what I did to App.UI.SlaveInteract.generateRows with this. Is there a better way you can think of? Maybe I should just make new system just for this page.

    • I'd consider composing it into a different function.

      For example: imagine a function whose only responsibility was to look at a single RowItem and, if it was not already disabled, but was already active, set the disabled property appropriately. That function would have just one job, and generateRows would not be responsible for that job anymore...the existing code to handle disabled would be enough.

      Then, you could assemble that into a loop that runs through an entire array of RowItems, applying that function to them each, and then instead of calling generateRows(array, ... you could call generateRows(disableSelected(array), ..., if you wanted the selected items disabled.

    • That's... basically what I wound up doing. TYVM.

    • Please register or sign in to reply
  • merged

  • Pregmodder mentioned in commit 0aaa1189

    mentioned in commit 0aaa1189

Please register or sign in to reply
Loading