ReformCopyright authored 5 years ago and FarawayVision committed 5 years ago

Rename opponent-card and opponent-cards-container to match the classes of the child items and avoid confusion with the playing card containers on the game screen.

We don't need two now that we have display: flex; instead of display: table; and display: table-cell.

Fixes problem with <i> elements in epilogue text causing line breaks in combination with display: flex; by wrapping the text in a <span>.

This should actually only be a concern if the loading is *very* slow for whatever reason.

* Prevents the space key from pushing buttons at the same time as advancing the game (caused the game to advance two phases at a time if the main button had focus).
* Sets focus in each modal.
* Disables game key handler whenever a modal is displayed instead of toggling a variable in only some cases.
* Blocks tabbing to control on the screen in the background whenever a modal is displayed.
* Adds a focus indicator so you can know where you're tabbing.

Extended Formatting: move stylesheet load to onSelected and unload stylesheets when removing characters

Autodetection of creator names isn't (and will never be) perfect.
Character creators are listed in inconsistent formats and different spellings, etc.
But this gets 95% of cases right, and in all other cases you can just type in a (partial) creator name yourself to get it right.

 * Reduce font sizes to prevent unintended wrapping in portrait orientation
 * Set filter label background to match details display label background
 * Make filter label/value rows meet flush at border
 * Make gender filter buttons more compact
 * Make linecount calculation more responsive by dividing batches by runtime vs. number of states

This popup points players who are searching for a missing character towards the FAQ.

Add a hasTag method to Player, which calls canonicalizeTag, avoiding code duplication and allowing the tag representation to be changed.

Also canonicalizeTag shoulnd't return ''. Either change on its own resolves a bug where <condition> elements without a filter attribute would never match, because we'd be looking for a blank tag.

* canonicalizeTag(tag) converts a tag into its 'canonical' form:
  - no spaces
  - all lowercase
  - aliases, if any, processed

* expandTagsList(input_tags) canonicalizes a list of tags:
  - All tags within the list are canonicalized
  - Any implied tags are added
  - Duplicate tags are removed

* Handling of tag modifications from alternate costumes has been simplified:
    The set of tags applied to the base opponent (without implied tags) is stored within a baseTags list on the Opponent object.
    All modifications specified by alt. costumes are applied to a copy of baseTags, before expandTagsList is applied.

* All places that use user-input tag names (dialogue conditions, tag search, etc.)
  have been modified to use canonicalizeTag.

* Use selection_image in opponent selection quads.
* Keep costume selection. Only unload selected alternate costume if another costume is selected (including default).
* Apply forced selection by calling .selectAlternateCostume() when Opponent object is instantiated instead of doing that when loading behaviour.xml and only setting selection_image upon instantiation.
* Initialize costume members in Opponent() rather than Player() since Opponent() doesn't call Player().

Note that selected_costume is the selection on the selection screen (the costume folder name) and alt_costume is the object containing metadata of the loaded costume. We need to add the costume base folder to that object to be able to know if the player has selected a different costume.

Also fill datalist elements right when all metadata have been loaded so that we don't end up with partial list in case the user manages to open a filter modal before that.

Also sort datalists.

This code might be a bit messy, but it seems to work after basic testing.

This'll help track what player tags are in use and help writers know what to target.

Make complex poses work on the main select screen, ensure that
sprites are centered w.r.t the pose box if overfull

Note: Only when individuallty selected; when a group is selected, all characters arrive simultaneously, so it doesn't make sense to trigger an opponent_selected event, and all slots are prepared so they can all see which other characters are selected.

When using the random buttons, up to three opponents could already be present, but it's still to complicated to handle.

I hope I sprinkled the right amount of volatile behaviour updating and behaviour committing.

This changes the strategy from trying to load metadata for all characters included on preset tables
(and failing on spnati.net when it comes to the offline tables) to only setting up those tables where
all characters' development statuses are among those enabled, or "testing". All characters in testing
should be on a testing table, so we don't load anyone needlessly.

Load preset tables the same way when using the Random Table button so that the Full Moon table works.

The commit SHA was already added to bug report data, but not to usage reports.

This reverts commit 40ac027d4df47192703ba6bfadbbb746d77b2078.

I intentionally don't run fixupDialogue() on the text included in bug reports.