Move hands from the separate array to the player objects. Change determineHand() and determineAIAction() to take an object instead of an index. Use the CARDS_PER_HAND constant; players don't have different numbers of cards.

Set up player arrays uninitialized and use delete to remove players. This simplifies iteration since e.g. .forEach() skips such nonexisting array slots, but doesn't skip null.

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

Always make hand.value an array so that we don't have to handle strength > TWO_PAIR as a separate case, simplifying determineLowestHand() considerably.

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

* Looking for quads, trips, and pairs going from ace down to deuce there is no need to translate 1 into 14.

* The value of any hand is never 0, so there's no need to use -1 to mean "none".

* When looking for straights, it's impossible to find two or more cards of the same rank since we're only looking for straights if we haven't found any pairs or better.

* The value of a hand is built the same way for flushes as for high cards.

To avoid too much repetition, don't comment on masturbating player during deal phase if it can be done during exchange phase, and don't have all players talk every time.

Pause with "Next" button when human player is out and *any* player is masturbating, and the deal animation delay is insufficient.

Talk about/to a masturbating player whenever possible, with double chance of addressing the human player.

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

Keep track of the auto forfeit timeout specially and cancel it right away after auto forfeit is turned off and the options dialog closed, for UX reasons.

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

Abort animations and timers when resetting the game. Clear the card displays when starting a new game, because the card animation callback aren't called until after restartGame() finishes.

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

No need for the "Next" phase. There is enough time to read during while the cards are being dealt (at least on normal speed).

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

Restructure tickForfeitTimers() to first check for a player about to cum, then decrement all other timers. More common code is kept together that way and it eliminates an inconsistency/bug when one player goes into heavy masturbation at the same time as another cums.

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

Instead of randomly refreshing masturbation comments during the wait phases, do it every 4 phases. Make sure that the main button starts on "Wait".

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

Handle NPCs commenting on either the PC or other NPCs masturbating in the same manner, while dealing the cards, not randomly for just 400 ms (no delay is needed during the waiting phases).

ReformCopyright authored 6 years ago and ReformCopyright committed 6 years ago

Since we're already determined in the reveal phase whether stripping or masturbation will happen, those cases can be separated into different functions. Move the masturbation setup code to spniForfeit.js where it belongs.

Part 3 of "Embarrassed cutie Nagisa's bonus dialogue event!"

Nagisa is now over 1000 lines, a 50% increase over her launch total! Hooray!

In this commit, I also replaced `~name~` with `~Name~` at the start of sentences, which is some new tech by ReformCopyright. In most cases, this won't be noticable, but Nagisa will now capitalize the first letter of a lower case player's name when it starts a sentence. (e.g. "darling" or "master")

Move remaining opponents

See merge request spnati/spnati.gitlab.io!719

Keep ALL opponents (except the re-skins) in opponents/

See merge request spnati/spnati.gitlab.io!646

Updates Launch images for Niels

See merge request spnati/spnati.gitlab.io!718

Include testing and offline characters offline; install a version of config.xml without those to production.