Make the eslint job not fail despite errors type warnings.

.gitlab-ci.yml

@@ -14,10 +14,8 @@ eslint:
     - npm install
     #- npm ci ### should use this for automated testing instead of "npm install", but we need a package-lock.json for it.
     - npm install eslint-formatter-gitlab
-    - npx eslint --format gitlab .
-  # errors make eslint return 1, for now though we want the pipeline not to ail when we eslint errors.
-  # trying to add " ; exit 0" or " ; echo 0" let the build fail anyways for some reason.
-  allow_failure: true
+    # > /dev/null 2>&1 || FAILED=true to make error type warnings not fail the job
+    - npx eslint --format gitlab . > /dev/null 2>&1 || FAILED=true
   artifacts:
     reports:
       codequality: gl-codequality.json