Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
fc-pregmod
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
pregmodfan
fc-pregmod
Commits
6064322c
Commit
6064322c
authored
3 years ago
by
Blank_Alt
Committed by
Pregmodder
3 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Improve contrib
parent
294876bf
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!10711
Improve contrib
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
CONTRIBUTING.md
+6
-9
6 additions, 9 deletions
CONTRIBUTING.md
with
6 additions
and
9 deletions
CONTRIBUTING.md
+
6
−
9
View file @
6064322c
...
...
@@ -141,15 +141,11 @@ const foo = {
New code should generally get organized into the
`App`
namespace. See
[
fc-js-init.js
](
js/002-config/fc-js-init.js
)
for a rough outline.
## JavaScript Features
*
Avoid using very new JavaScript features
*
Generally, we're currently targeting ECMAScript 2018, though we use a few widely-implemented ECMAScript 2019
features, like
`globalThis`
.
*
Conversely, do use modern features, it's not 2010 anymore and we don't try to support Internet Explorer or anything
stupid like that.
*
use
`let`
/
`const`
rather than
`var`
*
prefer fat arrow functions to inline long-form functions
*
etc.
*
Generally, we're currently targeting ECMAScript 2021.
*
It's not 2010 anymore and we don't try to support Internet Explorer or anything stupid like that.
*
use
`let`
/
`const`
rather than
`var`
*
prefer fat arrow functions to inline long-form functions
*
etc.
## Code quality
...
...
@@ -214,3 +210,4 @@ errors, it's not totally clean as is and there are a few false positives.
*
[
Classes in Game State
](
https://gitgud.io/pregmodfan/fc-pregmod/-/issues/696
)
*
[
Self executing functions
](
https://gitgud.io/pregmodfan/fc-pregmod/-/issues/2325
)
*
[
Sort a map
](
https://gitgud.io/pregmodfan/fc-pregmod/-/issues/2642
)
*
[
How to create a Merge Request (MR)
](
https://gitgud.io/pregmodfan/fc-pregmod/-/issues/3903
)
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment