Random issues part 2.

• pitFight.js: unused return value ln 20
• sePCBirthday.desc.js: review ln 1043-1045
• incubatorInteract.js: useless assignment to linkArray ln 141, row ln 1121, p ln 1463
• ads.js: payVarietyBonus and payAdBonus are identical
• siWork.js: useless assignment p ln 46, linkText ln 192
• familySummaries.js: return value of concat unused ln 530
• penthouse.js: function expects 2 arguments, but 3 were provided, ln 70
• birth.js: unexpected expression ln 864,

@lowercasedonkey @svornost

Got another set of reports to work out.

Huh, I see the birth one but it doesn't error for me. What error checking is this guy using?

Not a clue, but it can produce false positives.

marked the checklist item birth.js: unexpected expression ln 864, as completed

marked the checklist item incubatorInteract.js: useless assignment to linkArray ln 141, row ln 1121, p ln 1463 as completed

marked the checklist item siWork.js: useless assignment p ln 46, linkText ln 192 as completed

mentioned in merge request !8321 (merged)

marked the checklist item pitFight.js: unused return value ln 20 as completed

mentioned in merge request !8322 (merged)

marked the checklist item sePCBirthday.desc.js: review ln 1043-1045 as completed

marked the checklist item familySummaries.js: return value of concat unused ln 530 as completed

marked the checklist item penthouse.js: function expects 2 arguments, but 3 were provided, ln 70 as completed

That's a nice batch of actual bugs.

marked the checklist item ads.js: payVarietyBonus and payAdBonus are identical as completed

closed with merge request !8322 (merged)

mentioned in commit 294a802b