Running BC resets squad size of Military squads

I'm Running This save was created using FC version 0.10.7.1 build 1112. You are currently playing version: 0.10.7.1, mod version: 3.8.4, build: 1112, commit: 0682999a

If i do a backward compatibility update it resets my squads of Militia, Slaves & Mercenaries from 50 back down to 30.

It has been doing this for a while but I only just really noticed this week

changed the description

assigned to @Blank_Alt

A related issue (exploit) is that you can now use the replenish unit option to add units that you don't have to a squad. Say you've just made a new mercenary squad but you only had three mercs. Now there's a battle this week. A couple of mercs migrated to your city so the replenish all units option is available. At the moment you can keep hitting that until your mercenary squad is 50 strong with mercs that shouldn't be available. Works on any slave squads that aren't full, too, using the couple of menials you get at week end. You can do it in the Barracks, too.

@pmf
Can you please try this build and see if it solves both issues as it works in local testing but it never hurts to have outside testing.
https://anonfiles.com/vdG4O560p5/hotfix-collection-testing-0_html

Will do just as soon as I get back up to that stage of my current play through. I tend to restart a lot and I didn't keep any old saves. I should be able to let you know within a day.

To be clear at this stage only the BC issue is very likely fixed.
Hopefully either tonight or at some time on the weekend I can resolve the "Replenish all" issue.

Ah, gotcha. With hindsight, checking probably didn't need to wait anyway because slave and merc units should work the same way.

version: 0.10.7.1, mod version: 3.8.5, build: 1115

I'm on Week 23 so no mercs are available yet. I'm managing with a squad of drones and one squad of 30 max slaves. I've been skipping the officer training upgrades because of the bug. I have one free menial slave so I bought both officer upgrades and then kept hitting replenish until the squad was 50 strong. I then ran backwards compatibility. Squad size reverted to 30, both officer upgrades are unpurchased and I'm back to 1 free menial slave (not 20). This was just to confirm the bug.

version: 0.10.7.1, mod version: 3.8.5, build: 1115, commit: 7d974c72

Ok. First I applied backwards compatibility. Then I bought the officer upgrades and replenished up to 50 with my one menial, so that exploit is still current as you warned. I then ran backwards compatibility. Officer upgrades remain purchased and squad remains 50 strong. This build works.

Just to be redundantly sure I finished the week and got a battle. Slave unit was still at 50. I then ran BC again at the next opportunity and the max is still 50. One thing that did do is remind me of a minor issue I forgot to report. For a while now the slave unit is being displayed as "1st undefined". It used to be something like "1st slave unit" from memory.

mentioned in merge request !8664 (merged)

mentioned in commit 0e128f98

closed with merge request !8664 (merged)