Pregnancy does not prevent impregnation until passage updates again

Certain slave interactions don't seem to update the appropriate values to prevent impregnation until the interact passage has been refreshed again by other means, similar to #5649 (closed), though that's been an issue for quite a long time, while this appears to be new. I would assume something to do with humungusluver's recent work on fertility, but I'm not sure.

To give a specific example, remaining on the interact page, take a non-pregnant fertile slave. Click "Impregnate ${him} yourself" for fPCImpreg, check her pregnancy status in console (let's say she's now pregnant with triplets), and notice that fPCImpreg is still on the list of available interactions; click it again, check her pregnancy again and see that she's now carrying octuplets, and note that fPCImpreg has now disappeared from the list. Congratulations, you've double-impregnated your slave.

This occurs regardless of genetic quirks or modifications. Slaves with superfetation can have their pregnancy added to twice in the same week, just like normal slaves can be impregnated twice.

Impregnating the slave and then, say, kissing her, also removes impregnation actions from the list. Taking some other actions that can cause pregnancy, such as fVagina, fButt, and (with mpreg) fAnus, cannot cause double pregnancy themselves due to using tryKnockMeUp instead of knockMeUp, but do still keep fPCImpreg available (and able to reimpregnate) until one extra update has occurred. fSlaveSlaveImpreg is an interesting case, correctly making other impregnation options unavailable on the first go, but aborting and lying to you that you have no virile slaves if you try to use it after impregnating the slave by other means. fSlaveSelfImpreg behaves exactly like fPCImpreg.

All testing was done with V.menstruation disabled. Oddly, when I enabled it, fPCImpreg, fSlaveSlaveImpreg, and fSlaveSelfImpreg all totally disappeared from my fertile slaves' interaction options, even though they could still get knocked up through fVagina and such; because of this, I was unable to test if double-impregnation was possible under that setting.

changed the description

It might need something like what threatening a slave has. That or they need to refresh the slave interact passage.

Having menstruation on disables the impregs if you do not know she is fertile yet. Having it always unknown completely disables it pending rework to accommodate it.

This was caused by the interaction becoming a pop up, I'm pretty sure.

Oddly, when I enabled it, fPCImpreg, fSlaveSlaveImpreg, and fSlaveSelfImpreg all totally disappeared from my fertile slaves' interaction options, even though they could still get knocked up through fVagina and such

I'm adding these interactions back in right now and I see the same issue. I'm taking a look, but I think its the update loop, my guess is that the passage gets updated when you click interact, but it happens BEFORE the variables are set in the interaction. So like:

check if preg is true to show passage -> run passage -> passage is updated -> set preg to true -> go back to page and option still there

I'm seeing if I can fix this. Long term, I feel like we need to move these interactions that are essentially an Assignment elsewhere, like I see the Aztec one with a TODO like:

TODO: fix this interaction. Consider that it "takes a week" but is not tied to endweek. Consider how easy it is to cheese for rep gains.
			 should probably be an assignment more than an interaction. - Pregmodder

We do have part time assignments now, thinking on it.

Ahh i think found the issue, refresh is happening before the interaction happens not after:

						// refresh the host passage, to pick up changes to slave
						refresh();
						document.getElementById(miniSceneId).replaceChildren(sexOption.scene());

ill fix in my upcoming PR

If you refresh after it'll break differently (and worse).

The correct solution is to store the output, then refresh, then display (which is what it used to do).

// run the scene first, storing the results
const output = sexOption.scene();
// refresh the host passage, to pick up changes to slave
refresh();
// display the results
document.getElementById(miniSceneId).replaceChildren(output);

mentioned in merge request !12367 (merged)

mentioned in commit 9a83cf8c

closed with merge request !12367 (merged)