Skip to content
Snippets Groups Projects
  1. Apr 15, 2017
    • Master-Fate's avatar
      Trigger counts only when Credit screen is shown · 5615bee2
      Master-Fate authored
      The calls to count line and images should now only be called when the
      Credit screen is active. This should hopefully reduce the number of calls
      overall.
      5615bee2
    • Master-Fate's avatar
      09451e07
    • Master-Fate's avatar
      Fix the null case for behaviour file retrieval · cacc6e9a
      Master-Fate authored
      Such as when there are fewer than 4 individuals shown, e.g. as a result of
      a search/filter.
      cacc6e9a
    • Master-Fate's avatar
      Differentiate individual and group counting · 1ee48ab2
      Master-Fate authored
      Counting handlers will now trigger for group members on the group
      selecrion screen on page change or credits button.
      
      Once again, if line/image counts for a character have already been loaded,
      they will not be loaded again. However, because of the way the
      loadGroupMemberMeta code is written, characters whose counts were loaded
      on the individual select screen are different from those on the group
      selection screen, so browsing groups for the first time this session WILL
      cause the behaviour.xml file to be fetched.
      
      TL;DR: Group Select screen Misty and Individual Select screen Misty are
      are two different players, so the Misty behaviour.file is fetched twice.
      The way group members are loaded would have to be rewritten to reduce the
      number of calls further.
      1ee48ab2
    • Master-Fate's avatar
      Add documentation for count functions · ced8dbcd
      Master-Fate authored
      ced8dbcd
    • Master-Fate's avatar
      Trigger line counting on selection page change · bee4fc1d
      Master-Fate authored
      The call to behaviour.xml to compute unique line counts is now triggered
      for characters currently on the selection screen in the following situations:
      
      (1) That character's line or image count is not already loaded, AND
      (2) The user presses the Credits button, OR
          the user changes pages
      On first run, this will increase the number of calls to characters'
      behaviour files by four, but it should not be needed upon subsequent
      loads. Ideally the calls should not be made unless the Credits screen is
      displayed, so that might be an avenue worth exploring.
      
      This commit also introduces JS Promises into the code, which are cleaner
      than chaining AJAX success callbacks. However, they are newer, so they may
      or may not impact older or mobile browsers (MDN suggests they are at least
      supported by most). Should they cause problems, either they will need to
      be rewritten, or more preferably, be substituted with a polyfill.
      bee4fc1d
  2. Apr 14, 2017
  3. Apr 13, 2017
  4. Apr 12, 2017
  5. Apr 11, 2017
Loading